fix: change the timing of sdk context destruction. #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2021.0 #1123 +/- ##
============================================
- Coverage 81.20% 81.13% -0.07%
+ Complexity 1683 1682 -1
============================================
Files 252 252
Lines 5729 5726 -3
Branches 674 673 -1
============================================
- Hits 4652 4646 -6
- Misses 688 691 +3
Partials 389 389
|
SkyeBeFreeman
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bugfix
Describe what this PR does for and how you did.
Move the SDK context destroy invocation from Polaris config to Polaris context in order to complete context destruction
Adding the issue link (#xxx) if possible.
Note
Checklist
Checklist (Optional)